Skip to content

jj stderr fix#47

Merged
hugoh merged 2 commits into
mainfrom
jj-stderr-fix
Jul 2, 2026
Merged

jj stderr fix#47
hugoh merged 2 commits into
mainfrom
jj-stderr-fix

Conversation

@hugoh

@hugoh hugoh commented Jul 2, 2026

Copy link
Copy Markdown
Owner
  • refactor: dedupe repo shell-complete, tui repo-set, table cell writers
  • fix(jj): separate stdout/stderr in defaultRunJJ

hugoh added 2 commits July 1, 2026 21:46
@hugoh
refactor: dedupe repo shell-complete, tui repo-set, table cell writers
2f2455e 
cmd/repo.go: extract completeFirstArgWithRepos, shared by rename and
group/ungroup commands.
internal/tui: extract model.allRepoSet(), shared by initHistoryList and
openSelHistoryPopup.
internal/ui/table.go: merge writeHeader/writeRow into writeCells with an
optional cell-style function.

Found via cpd; no behavior change.
@hugoh
fix(jj): separate stdout/stderr in defaultRunJJ
502893e 
Combined buffer let stderr warnings during working-copy re-snapshot
corrupt the JSON parsed from stdout, breaking Status() with
"decode jj log output: invalid character" errors.

Add regression test stubbing jj on PATH to confirm stderr no longer
leaks into stdout.
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@deepsource-io

deepsource-io Bot commented Jul 2, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in c163c77...502893e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Jul 2, 2026 2:47a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.86%. Comparing base (c163c77) to head (502893e).

Files with missing lines Patch % Lines
cmd/repo.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   88.78%   88.86%   +0.07%     
==========================================
  Files          34       34              
  Lines        3638     3636       -2     
==========================================
+ Hits         3230     3231       +1     
+ Misses        311      309       -2     
+ Partials       97       96       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugoh hugoh merged commit 6e3d5fc into main Jul 2, 2026
7 checks passed
@hugoh hugoh deleted the jj-stderr-fix branch July 2, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hugoh